fixed disabling of artic normalisation #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the disabling was activated in the pipeline (`--artic_normalize False`), no parameter was handed over to the artic pipeline, so that artic used the default value of 200. Normalisation is now correctly turned off by passing `--normalise 0` to the artic pipeline.
|
Looks good @MarieLataretu ! @replikation is on holiday the next week's so please feel free to merge and do a release Otherwise this maybe needs to wait until October :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the disabling was activated in the pipeline (
--artic_normalize False), no parameter was handed over to the artic pipeline, so that artic used the default value of 200. Normalisation is now correctly turned off by passing--normalise 0to the artic pipeline.