Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rki output and some smaller fixes #28

Merged
merged 4 commits into from
Jan 22, 2021
Merged

rki output and some smaller fixes #28

merged 4 commits into from
Jan 22, 2021

Conversation

replikation
Copy link
Owner

@replikation replikation commented Jan 21, 2021

  • rki style output branch

Missing:

  • pangolin lineage in rki csv
  • collect fastas into multifasta for rki

@replikation replikation self-assigned this Jan 21, 2021
@replikation replikation added the enhancement New feature or request label Jan 21, 2021
@replikation
Copy link
Owner Author

@hoelzer apparently rki does not have a "pangolin" field... so I skip adding this

@hoelzer
Copy link
Collaborator

hoelzer commented Jan 22, 2021

@hoelzer apparently rki does not have a "pangolin" field... so I skip adding this

@replikation what do you mean by "does not have a pangolin" field? The current DESH upload portal? No, currently there is no field to put the pangolin lineage.

@replikation
Copy link
Owner Author

@hoelzer yep DESH upload.

@hoelzer
Copy link
Collaborator

hoelzer commented Jan 22, 2021

@hoelzer yep DESH upload.

Yeah, this is the first very very basic form for the first days (phase 0, https://www.rki.de/DE/Content/InfAZ/N/Neuartiges_Coronavirus/DESH/DESH.html) and will be subject to change. So we just need to adjust the output format following changes to the upload portal in the next days/weeks

@replikation
Copy link
Owner Author

yep we need to do this either way as we are sequencing every week now

@replikation
Copy link
Owner Author

  • @hoelzer cleaned up output structure and added a combined fasta for the --rki flag
  • html output not in here ill do a separate PR for this

@replikation
Copy link
Owner Author

  • coul improve the "fastq collection" via find for the barcode dirs. then it would be "more" recursive stable...?

@replikation
Copy link
Owner Author

replikation commented Jan 22, 2021

@hoelzer
Copy link
Collaborator

hoelzer commented Jan 22, 2021

taxon,lineage,probability,pangoLEARN_version,status,note
FAO96286_barcode07,B.1.177,1.0,2021-01-11,passed_qc,

@replikation the column headers are not correct, or? First column is the sample or FASTA ID and not the taxon? Or is this just default pangolin output style (then let's keep it)

@replikation
Copy link
Owner Author

  • @hoelzer oh good find, this is from my "collect all pangolin report part" here, so it can be manually changed

@hoelzer
Copy link
Collaborator

hoelzer commented Jan 22, 2021

@replikation fine on my side! Nothing burned down :D checked on laptop and cluster and also with the new --fastq_raw option.

The comment above regarding lineage output is just minor

UPDATE: ah nice, then now everything fine! :)

@replikation replikation merged commit ed123b9 into master Jan 22, 2021
@replikation replikation deleted the report_file branch January 22, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants