-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only add genomes to final RKI FASTA and report.csv that meet QC criteria #31
Comments
|
need to extract the "valid" sequence name. i think this can also be done based on channels |
Should be fine for now, but might be subject to changes over the next days/weeks :) Maybe you can write to the summary rki folder:
By that, it should be also clear to the user what he can expect in every file? |
good idea. yeah i think ill add that tomorrow or so |
|
@replikation is there still an output multi FASTA file that has ALL sequences? Actually, we would need that as well for downstream processing. However, for other uses the direct split into valid and invalid is good so what I can also do is:
for my downstream tasks |
Question/Thought
I think currently in #28 all final consensus seqs are added to the
all_genomes.fasta
andrki_report.csv
?Whereas this is fine (because then all information is in one place) we could also think of just writing sequences to these summary files that also meet the consensus QC. Otherwise, they might be anyway rejected when submitted to RKI.
However, people might want to work also with sequences that don't meet the QC criteria internally and would otherwise miss them when they are not part of the summary files?
And: when QC thresholds change, this must be also reflected in poreCov to not reject sequences that might actually pass the later QC
The text was updated successfully, but these errors were encountered: