Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to pretty-print individual nodes #21

Merged
merged 3 commits into from
Dec 17, 2023

Conversation

Property404
Copy link
Contributor

Fixes #17

I used the Display impl here, which introduces inconsistencies because Fdt is pretty-printed with the Debug impl.
As I said in #18 , I am of the opinion that pretty-printing should happen in the Display impl, but I'll wait for feedback from the original author on the wanted direction here

@repnop
Copy link
Owner

repnop commented Dec 17, 2023

I'm honestly not sure why I stuck with using Debug for both, that's something I'll fix for the rewrite that's coming out, thanks.

@repnop repnop merged commit 6fc87b5 into repnop:master Dec 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add way to pretty-print individual nodes
2 participants