Remove superfluous transparent types #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was affected from changes in commit 2319fd3
|
Hi, thanks for the PR but I'm going to reject this one, the types are not superfluous because they ensure that integers with different endianness aren't accidentally used interchangeably, and how they're stored internally is irrelevant to that (and mostly a concern of performance). If you're not familiar with the newtype pattern in Rust, that's probably worth a read. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigEndianU32andBigEndianU64do not actually store their inner types in big endian, but in native endian, and are therefore superfluous. Removing them simplifies the code a bit