package: various fixups #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SA 3.3.2 has made Archive::Tar and IO::Zlib required at build time and refuses to build without them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I could find no reason to exclude augeas for el4 and the ExcludeDist was added with no explanation that I could find in the log. Strictly speaking you should not build vim-augeas for el4 since it requires a newer vim but there's no harm done.
ruby-augeas was not setup to build on rhel < 6 but with the included fixes it builds.
With those two commits I'm now able to build and install a puppet 2.7.3 stack on el4,el5,el6.
(Note though that the currently public facter 1.6.0 for el4 has been built noarch and is broken for i386, also this is not what the specfile says should happen and building it locally does the right thing.)
The last commit is just a few BRs that are needed for SA 3.3.2 or it will refuse to build.
-tgc