csvlint: Add csvlint engine #11
Merged
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukiisbored
reviewed
Dec 24, 2017
engines/csvlint/Dockerfile
Outdated
| FROM linterhub/image-ruby | ||
| LABEL maintainer="linterhub@repometric.com" | ||
| RUN apk add --no-cache libcurl && \ | ||
| apk add --update make \ |
There was a problem hiding this comment.
Why do you need update?
There was a problem hiding this comment.
csvlint needs make , the build fails otherwise.
There was a problem hiding this comment.
I doubt you need --update to get make.
There was a problem hiding this comment.
Yes, you are right, it worked without --update. Removing.
yukiisbored
reviewed
Dec 24, 2017
| "Foo","Bsr","Baz" | ||
|
|
||
| "Biff","Baff","Boff" | ||
| "Qux","Teaspoon","Doge" |
There was a problem hiding this comment.
Missing new line on EOF.
There was a problem hiding this comment.
On purpose, it will emit one more less error if added...
There was a problem hiding this comment.
Ah sorry, forgot this was a test case :P
Adds missing csvlint using ruby image. Closes #10
|
gah, I can't access the Docker cloud build. @xferra |
xferra
approved these changes
Dec 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing csvlint using ruby image.
Closes #10