Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox not working properly in break down by file type #1473

Closed
HCY123902 opened this issue Mar 10, 2021 · 0 comments · Fixed by #1475
Closed

Checkbox not working properly in break down by file type #1473

HCY123902 opened this issue Mar 10, 2021 · 0 comments · Fixed by #1475
Assignees
@gerhean
Labels
c.Bug d.Contributors p.Medium

Comments

@HCY123902
Copy link
Contributor

HCY123902 commented Mar 10, 2021 •
edited

Tell us about your environment

  • RepoSense Version: master
  • OS and Version: Windows10
  • Web Browser and Version (if applicable): Edge

Please include the steps to reproduce the bug.

  1. Open a report
  2. Tick the break down by file type checkbox
  3. Tick the All checkbox
  4. Untick the All checkbox
  5. Tick any checkbox of a specific file type
  6. Untick the checkbox
  7. Tick the All checkbox again

What was expected to happen?

The ramp chart should be empty and the line count of each author should be changed to 0 after unticking the All checkbox in step 4.

The commit and line count of each file type should be restored after ticking the All checkbox in step 7.

What actually happened? Please include a screenshot of the output.

The commit and line count are not changed after unticking the All checkbox in step 4.

image

The commit is empty and the line count is 0 after ticking the All checkbox in step 7.

image

If possible, include the URL to your RepoSense report or log files (if any).
@gerhean gerhean mentioned this issue Mar 12, 2021
Merged
@damithc damithc added this to For contributors in Roadmap Apr 4, 2021
fzdy1914 pushed a commit that referenced this issue Apr 23, 2021
@gerhean
[#1473] Add this.getFiltered() to set checkedFileTypes (#1475)
21b4f9c 
`this.getFiltered()` is not called when `checkAllFileTypes` is 
modified. This is regression introduced by PR #1440.

Let's call `this.getFiltered()` when `checkAllFileTypes` is 
modified.
@dcshzj dcshzj removed this from For contributors in Roadmap Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerhean gerhean

Labels
c.Bug d.Contributors p.Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1473] Checkbox not working properly in break down by file type gerhean/RepoSense
3 participants
@damithc @gerhean @HCY123902