-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1473] Checkbox not working properly in break down by file type #1475
[#1473] Checkbox not working properly in break down by file type #1475
Conversation
@gerhean there still seems to be some bug as noticed in deployment. Untick on any filetype that is not displayed in a specific repository. The line count doesn't change but the length of the contribution bar still changes for the specific repository.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial bug is fixed but can notice other bugs.
| Untick on any filetype that is not displayed in a specific repository. The line count doesn't change but the length of the contribution bar still changes for the specific repository. This other bug is caused by the computed property I don't think this bug will be as simple to fix at least, since I feel the best way to fix this is to make each summary chart its own component, such that we can compute a single repoAvgContributionSize per summary chart. Another way would be to fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message should be getFiltered
instead of just filtered
, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, in the PR message, please also specify this is regression introduced by PR [#1440]
@Tejas2805 I think I went through this before when I implemented this feature and at that time we agreed that this problem is tolerable. |
@Tejas2805 So can the other bugs be fixed in a separate PR if needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Fixes #1473