Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1448] Update documentation to remove need for personal access token #1465

Merged
merged 6 commits into from
Mar 28, 2021

Conversation

dcshzj
Copy link
Member

@dcshzj dcshzj commented Mar 7, 2021

Associated pull request: reposense/publish-RepoSense#9.
Part of #1448.

This is the button that users have to press to enable GitHub Actions:
image

Users need to specify a personal access token or a deploy key to
automate the generation of the RepoSense report. This is an
additional step that makes using this repository less
user-friendly for new users.

Let's update the documentation to remove the need for the user to
generate a personal access token, since the GITHUB_TOKEN is
automatically used when generating a report in GitHub Actions.

Currently, users need to specify a personal access token or a
deploy key to automate the generation of the RepoSense report.
This is an additional step that makes using this repository less
user-friendly for new users.

Let's update the documentation to remove the need for the user to
generate a personal access token, since the GITHUB_TOKEN is
automatically used when generating a report in GitHub Actions.
@dcshzj dcshzj requested a review from a team March 7, 2021 09:10
@damithc
Copy link
Collaborator

damithc commented Mar 7, 2021

Some minor things to note:

  • Avoid adding screenshots that don't bring much value. They could get outdated easily when GitHub changes the UI.
  • Use Part of #1234 instead of Fixes #1234 if the whole issue is not fixed by the PR. Otherwise the issue can get closed prematurely when only part of it is fixed.
  • Can omit Currently, from the commit message as it is implied.

Copy link
Contributor

@HCY123902 HCY123902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzdy1914 fzdy1914 requested a review from a team March 15, 2021 08:46
Copy link
Contributor

@Tejas2805 Tejas2805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments.

docs/ug/withGithubActions.md Outdated Show resolved Hide resolved

<include src="withTravis.md#section-edit-configs" />

{{ step(5)}} **View the generated report:**
{{ step(4)}} **View the generated report:**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR but can the image of this step somehow be made a bit more prominent? As of now, it's looking a bit absurd the way it is displayed. Can do it in a different PR.

1. Add a new secret with the name `ACCESS_TOKEN` or `DEPLOY_KEY` (depending on your earlier choice) and the value of the token/key you copied earlier.<br>
![GitHub Actions Secrets](../images/publishingguide-secrets.png "GitHub Actions Secrets")
1. Go to the `Actions` page of your fork of the [publish-RepoSense](https://github.com/reposense/publish-RepoSense) repo.
1. Click on the green button that says `I understand my workflows, go ahead and enable them` to enable GitHub Actions on your new repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't seem to find this button on any of my repositories. Can show me where it comes and how?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be forked to an account that has never forked the publish-RepoSense repository I think. I reproduced the above message by forking the repository to an empty organisational account.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for publish-RepoSense first time? Or whenever someone who hasn't enabled GitHub Actions earlier needs to do this for the first time? In my opinion, I think it's the second case. If it is, then maybe better to add the fact that this step needs to be done only if enabling Actions for the first time. If it is not, then LGTM!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the first case where you need to enable it for the first time you fork the repository. Also, GitHub only allows for forking a particular repository once per account, so it will refer to the first time that a particular account has forked the repository.

Copy link
Contributor

@Tejas2805 Tejas2805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Rest LGTM!

@dcshzj
Copy link
Member Author

dcshzj commented Mar 26, 2021

Left a comment. Rest LGTM!

Is it possible to review reposense/publish-RepoSense#9 as well? That should be merged before this PR is merged.

@dcshzj dcshzj requested a review from a team March 26, 2021 03:02
@fzdy1914 fzdy1914 merged commit d7e5d42 into reposense:master Mar 28, 2021
@dcshzj dcshzj deleted the 1448-token-publish-reposense branch June 2, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants