-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilise GITHUB_TOKEN to commit to gh-pages and deploy #9
Conversation
Currently, users need to specify a personal access token or a deploy key to automate the generation of the RepoSense report. This is an additional step that makes using this repository less user-friendly for new users. Let's make use of the autogenerated GITHUB_TOKEN when using GitHub Actions to automatically push to the gh-pages branch and to trigger a GitHub Pages build.
I can't add reviewers on this repository, so pinging the team: @reposense/21-22-active-developer. |
@@ -23,8 +23,10 @@ jobs: | |||
- name: Generate report | |||
run: bash ./run.sh | |||
- name: Deploy GitHub pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I ask whether the original personal access token will work after making this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't want to use the personal access token in GitHub Actions as the GitHub token is sufficient.
There seems to be some issue in the report in https://dcshzj.github.io/publish-RepoSense/ from my side. Is it intended or will it be possible that you can use this action flow to generate another report? Thanks |
Yep, this is intended. This is due to the original settings of the report that only generates the report for the previous month, and is out of scope of this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pinging the next stage of reviewers: @reposense/stage-1-active-reviewer. |
Re-pinging: @reposense/stage-1-active-reviewer |
Part of reposense/RepoSense#1448.
Test action flow: https://github.com/dcshzj/publish-RepoSense/actions/runs/629123865
Generated report: https://dcshzj.github.io/publish-RepoSense/ (uses default values of this repository)