Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilise GITHUB_TOKEN to commit to gh-pages and deploy #9

Merged
merged 1 commit into from
Mar 28, 2021

Conversation

dcshzj
Copy link
Member

@dcshzj dcshzj commented Mar 7, 2021

Part of reposense/RepoSense#1448.

Test action flow: https://github.com/dcshzj/publish-RepoSense/actions/runs/629123865
Generated report: https://dcshzj.github.io/publish-RepoSense/ (uses default values of this repository)

Users need to specify a personal access token or a deploy key to
automate the generation of the RepoSense report. This is an
additional step that makes using this repository less
user-friendly for new users.

Let's make use of the autogenerated GITHUB_TOKEN when using
GitHub Actions to automatically push to the gh-pages branch and to
trigger a GitHub Pages build.

Currently, users need to specify a personal access token or a
deploy key to automate the generation of the RepoSense report.
This is an additional step that makes using this repository less
user-friendly for new users.

Let's make use of the autogenerated GITHUB_TOKEN when using
GitHub Actions to automatically push to the gh-pages branch and to
trigger a GitHub Pages build.
@dcshzj
Copy link
Member Author

dcshzj commented Mar 7, 2021

I can't add reviewers on this repository, so pinging the team: @reposense/21-22-active-developer.

@@ -23,8 +23,10 @@ jobs:
- name: Generate report
run: bash ./run.sh
- name: Deploy GitHub pages

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask whether the original personal access token will work after making this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't want to use the personal access token in GitHub Actions as the GitHub token is sufficient.

@HCY123902
Copy link

image

There seems to be some issue in the report in https://dcshzj.github.io/publish-RepoSense/ from my side. Is it intended or will it be possible that you can use this action flow to generate another report? Thanks

@dcshzj
Copy link
Member Author

dcshzj commented Mar 12, 2021

There seems to be some issue in the report in https://dcshzj.github.io/publish-RepoSense/ from my side. Is it intended or will it be possible that you can use this action flow to generate another report? Thanks

Yep, this is intended. This is due to the original settings of the report that only generates the report for the previous month, and is out of scope of this pull request.

Copy link

@HCY123902 HCY123902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcshzj
Copy link
Member Author

dcshzj commented Mar 15, 2021

Pinging the next stage of reviewers: @reposense/stage-1-active-reviewer.

@dcshzj
Copy link
Member Author

dcshzj commented Mar 23, 2021

Re-pinging: @reposense/stage-1-active-reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants