-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1936] Migrate store.js to TypeScript #1937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! I just have a few questions about typing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just added a ESLint exception in c010d83 for the empty interface in preparation for #1913 to be merged - empty interfaces are usually not meaningful, but this case is an exception. Because the empty/"repeated" interface is inside the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @ckcherry23 caught the points that I want to bring up. Thanks for the help!
The following links are for previewing this pull request:
|
Part of #1936
Proposed commit message
Other information
The declaration of the module and
ComponentCustomProperties
invuex.d.ts
provides type definitions to thethis.$store
object that's used in the.vue
files.Also, although I have checked on my end, this PR should probably not be merged until after #1913 , so we can see the updated results of the CI that includes the new TypeScript rules.