Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2109] Add search by tag functionality #2116

Merged
merged 13 commits into from
Mar 19, 2024
Merged

[#2109] Add search by tag functionality #2116

merged 13 commits into from
Mar 19, 2024

Conversation

jonasongg
Copy link
Contributor

@jonasongg jonasongg commented Feb 16, 2024 •
edited

Fixes #2109

Proposed commit message

Add search by tag functionality

It can be useful to search author/repos by git tags.

Let's add this functionality to make it easier to filter by tags.

Other information

@jonasongg jonasongg requested a review from a team February 16, 2024 17:02
@damithc
Copy link
Collaborator

damithc commented Feb 17, 2024

Proposed commit message

Add search by tag functionality

Currently, there is no way to search repos/users by tags. 

Let's add this functionality to make it easier to filter by tags.

Two minor comments about the commit message:

It's common to omit the Currently, as it is implied anyway.
When adding a new feature, we can omit the 'problem' section i.e., Currently, there is no way to search repos/users by tags.
Instead, justify the feature.

Add search by tag functionality

It can be useful to ...

Let's add ...

@damithc
Copy link
Collaborator

damithc commented Feb 17, 2024

Another thing: any changes to the UI must come with a corresponding change to the UG, and most likely, tests as well.

@jonasongg jonasongg changed the title Add search by tag functionality [#2109] Add search by tag functionality Feb 17, 2024
@jonasongg
Copy link
Contributor Author

jonasongg commented Feb 17, 2024 •
edited

@damithc Thanks prof for the feedback! I've made the changes

sopa301
sopa301 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have one question.

frontend/src/views/c-summary.vue Outdated Show resolved Hide resolved
@ckcherry23 ckcherry23 requested a review from a team March 2, 2024 01:38
@jonasongg
Copy link
Contributor Author

thanks @sopa301 @ckcherry23! just implemented the changes suggested

sopa301
sopa301 approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vvidday
vvidday reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this! Have a question about the tests.

frontend/src/views/c-summary.vue Outdated Show resolved Hide resolved
frontend/cypress/tests/chartView/chartView_toolBar_searchBox.cy.js Show resolved Hide resolved
@jonasongg
Copy link
Contributor Author

@vvidday thanks for the comments! i have implemented some changes to address them

@vvidday vvidday self-requested a review March 16, 2024 09:06
vvidday
vvidday approved these changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes, LGTM!

ckcherry23
ckcherry23 approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this feature @jonasongg!

frontend/cypress/tests/chartView/chartView_toolBar_searchBox.cy.js Outdated Show resolved Hide resolved
@ckcherry23 ckcherry23 merged commit 147f473 into reposense:master Mar 19, 2024
10 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

ckcherry23 added a commit that referenced this pull request Mar 19, 2024
@ckcherry23
Revert "[#2109] Add search by tag functionality (#2116)"
0458add 
This reverts commit 147f473.
@ckcherry23 ckcherry23 mentioned this pull request Mar 19, 2024
Merged
ckcherry23 added a commit that referenced this pull request Mar 20, 2024
@ckcherry23
[#2164] Revert "[#2109] Add search by tag functionality" (#2165)
cc0651f 
Reverts PR #2116 to fix single group bug

Merging PR #2116 has caused all analysed charts to appear in a single group. 

Let us revert that merge commit as a hotfix to restore the original behaviour
while we investigate a solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@vvidday vvidday vvidday approved these changes

@sopa301 sopa301 sopa301 approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give a way to find repos with a specific tag
5 participants
@jonasongg @damithc @vvidday @ckcherry23 @sopa301