Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2164] Revert "[#2109] Add search by tag functionality" #2165

Merged
merged 1 commit into from
Mar 20, 2024
Merged

[#2164] Revert "[#2109] Add search by tag functionality" #2165

merged 1 commit into from
Mar 20, 2024

Conversation

ckcherry23
Copy link
Member

@ckcherry23 ckcherry23 commented Mar 19, 2024 •
edited

Reverts #2116 to fix #2164

Reverts PR #2116 to fix single group bug

Merging PR #2116 has caused all analysed charts to appear in a single group. 

Let us revert that PR as a hotfix to restore the original behaviour while we
investigate a solution.

@ckcherry23 ckcherry23 changed the title Revert "[#2109] Add search by tag functionality" [#2164] Revert "[#2109] Add search by tag functionality" Mar 19, 2024
@ckcherry23 ckcherry23 requested review from a team March 19, 2024 23:34
jonasongg
jonasongg approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@jonasongg jonasongg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to replicate the issue locally, but if this will fix the issue on the dashboard until we can figure out what's wrong, LGTM!

MarcusTXK
MarcusTXK approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@MarcusTXK MarcusTXK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets merge this in first to fix the problem, and add a test for this in the future to replicate the current issue.

@MarcusTXK MarcusTXK requested a review from a team March 20, 2024 01:33
@ckcherry23 ckcherry23 merged commit cc0651f into master Mar 20, 2024
17 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

@jonasongg jonasongg mentioned this pull request Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gok99 gok99 gok99 approved these changes

@MarcusTXK MarcusTXK MarcusTXK approved these changes

@jonasongg jonasongg jonasongg approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reports show only one team
4 participants
@ckcherry23 @gok99 @MarcusTXK @jonasongg