Fix #41 (set charset of messages part of a multipart/alternative message correctly) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the bug described here: repoze#41 Rationale: get_content_charset() has been there in email.message.Message for a long time now, returning the charset of the body of the Message (which is what we are looking for there). get_charset() has been deprecated for some time now, returns None by default (even if a charset is set in the Content-Type header). There are some other ways to retrieve the charset (get_params(), get_param('charset'), message['Content-Type'].params) but get_content_charset() is the only one that exists through all existing python versions, and it is there even in the new email.message.EmailMessage class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info in the commit including the fix.
Tests pass.
Ok?
(thanks!)