Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xUnit execution on Linux & .NET Framework (Mono) #132

Closed
gasparnagy opened this issue May 14, 2024 · 2 comments
Closed

Fix xUnit execution on Linux & .NET Framework (Mono) #132

gasparnagy opened this issue May 14, 2024 · 2 comments
Labels
maintanance Issues related to the mainanance of the code-base: conde structuring, CI/CD, etc.

Comments

@gasparnagy
Copy link
Contributor

Reqnroll Version

1.0.1

Which test runner are you using?

xUnit

Test Runner Version Number

n/a

.NET Implementation

.NET Framework 4.6.2 or later

Test Execution Method

Visual Studio Test Explorer

Content of reqnroll.json configuration file

No response

Issue Description

The Reqnroll.SystemTests.Portability.PortabilityTestBase.GeneratorAllIn_sample_can_be_handled tests fail for xUnit on Mono (Linux). See #131.

The tests have been temporarily disabled in the method.

Steps to Reproduce

Remove disabling from Reqnroll.SystemTests.Portability.PortabilityTestBase.GeneratorAllIn_sample_can_be_handled, run CI

Link to Repro Project

No response

@gasparnagy gasparnagy added the bug Something isn't working label May 14, 2024
gasparnagy added a commit that referenced this issue May 22, 2024
…ons-dependencyinjection-plugin

* origin/main: (21 commits)
  Fix #56 autofac ambiguous stepdef and hook required #127 issue (#139)
  Reduce target framework of Reqnroll to netstandard2.0 (#130)
  Fix StackOverflowException when using [StepArgumentTransformation] with same input and output type (#136)
  MsTest: Replace DelayedFixtureTearDown special case with ClassCleanupBehavior.EndOfClass (#128)
  Temporarily disabled tests until #132 is resolved
  Add NUnit & xUnit core tests to portability suite
  Capture ExecutionContext after every binding invoke (#126)
  small improvement in CodeDomHelper to be able to chain async calls
  fix method name sources in UnitTestFeatureGenerator
  External data plugin, support for JSON files  (#118)
  UnitTests: Check if SDK version is installed and if not ignore the test (#109)
  Fix 111 ignore attr not inherited from rule (#113)
  Update README.md (#110)
  Fix 81 - modified CucumberExpressionParameterTypeRegistry to handle multiple custom types used as cucumber expressions when those types share the same short name. (#104)
  Update index.md
  Simplify test project targets (#105)
  Make SystemTests temp folder configurable and use NUGET_PACKAGES env var to override global NuGet folder
  Fleshing out Generation System Tests (2) (#99)
  Fix for 81 - Cucumber Expression using Enums errors when two enums exist with the same short name (#100)
  Include BoDi to Reqnroll package (#91) (#95)
  ...

# Conflicts:
#	Reqnroll.sln
#	Tests/Reqnroll.PluginTests/Reqnroll.PluginTests.csproj
@gasparnagy
Copy link
Contributor Author

I wonder whether this is a problem with Reqnroll, or xUnit itself. It only affects linux + .NET 4.6.2 or .NET 4.7.2. (.NET 4.8 and .NET 6+ works). Maybe we should just add this to the compatibility list and close this.

@gasparnagy gasparnagy added maintanance Issues related to the mainanance of the code-base: conde structuring, CI/CD, etc. and removed bug Something isn't working labels May 29, 2024
@gasparnagy
Copy link
Contributor Author

It seems that xUnit v2 (that we used in tests) is not officially supported by xUnit: https://xunit.net/docs/v3-alpha#v2-changes.

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintanance Issues related to the mainanance of the code-base: conde structuring, CI/CD, etc.
Projects
None yet
Development

No branches or pull requests

1 participant