Include BoDi to Reqnroll package (#91) #95
Conversation
|
@mbhoek @ajeckmans Having slept on it... Why do we have it in a separate assembly at all? If we will never deploy BoDi separately and it is always needed, it should be in the Reqnroll.dll... What do you think? |
|
I didn't want to say the same for fear of it being too out there an idea, but embedding BoDi within the Reqnroll assembly makes total sense - it's practically an implementation detail. |
|
@gasparnagy I'm fine with that, the only reason I kept it separate is because you asked me to in #40 😄 |
|
@mbhoek @Code-Grump Yeah... That's why sleeping makes sense. (A bit of history: BoDi was my first contribution to SpecFlow back in 2010 that I did in my free-time, because we were too busy at work and I could not progress with SpecFlow as I wanted. The "Bo" part of the "BoDi" name comes from the name of my first daughter, who way 1 year old at that time... Now she is 15 and in the national finals of the school programming contest, coding in Python and C++... 😄) |
I second that. |
…ons-dependencyinjection-plugin * origin/main: (21 commits) Fix #56 autofac ambiguous stepdef and hook required #127 issue (#139) Reduce target framework of Reqnroll to netstandard2.0 (#130) Fix StackOverflowException when using [StepArgumentTransformation] with same input and output type (#136) MsTest: Replace DelayedFixtureTearDown special case with ClassCleanupBehavior.EndOfClass (#128) Temporarily disabled tests until #132 is resolved Add NUnit & xUnit core tests to portability suite Capture ExecutionContext after every binding invoke (#126) small improvement in CodeDomHelper to be able to chain async calls fix method name sources in UnitTestFeatureGenerator External data plugin, support for JSON files (#118) UnitTests: Check if SDK version is installed and if not ignore the test (#109) Fix 111 ignore attr not inherited from rule (#113) Update README.md (#110) Fix 81 - modified CucumberExpressionParameterTypeRegistry to handle multiple custom types used as cucumber expressions when those types share the same short name. (#104) Update index.md Simplify test project targets (#105) Make SystemTests temp folder configurable and use NUGET_PACKAGES env var to override global NuGet folder Fleshing out Generation System Tests (2) (#99) Fix for 81 - Cucumber Expression using Enums errors when two enums exist with the same short name (#100) Include BoDi to Reqnroll package (#91) (#95) ... # Conflicts: # Reqnroll.sln # Tests/Reqnroll.PluginTests/Reqnroll.PluginTests.csproj
A change to #80
Discussed in #91