Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project template binding #169

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

mcraa
Copy link
Contributor

@mcraa mcraa commented Jun 10, 2024

Following the documentation and creating a new test project with dotnet new reqnroll-project then running dotnet test ends up with No matching step definition found for the step. Use the following code to create one: ...
This change adds the missing binding so following the steps in the documentation won't result in confusion anymore.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance improvement
  • Refactoring (so no functional change)
  • Other (docs, build config, etc)

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gasparnagy
Copy link
Contributor

Oh... What a stupid mistake... Thx @mcraa!

@gasparnagy gasparnagy merged commit ef67de7 into reqnroll:main Jun 10, 2024
4 checks passed
@gasparnagy
Copy link
Contributor

@mcraa Thank you for the contribution! According to our guidelines I have invited you to the Reqnroll contributors team. Congrats! 🎉 If you accept it, you will be able to make pull requests easier in the future.

You are also welcome on our discord server: https://go.reqnroll.net/discord-invite

gasparnagy added a commit that referenced this pull request Jun 12, 2024
* main:
  Reqnroll.Verify: Support for Verify v24 (Verify.Xunit v24.2.0) for .NET 4.7.2+ and .NET 6.0+. (#151, #170)
  use pull_request_template.md from the .github repo
  Fix spelling mistake in CONTRIBUTING.md
  Bump version
  fix config docs
  Add release contributors to CHANGELOG (#171)
  Update CONTRIBUTING with "draft PR" workflow and no force push after review
  fix CHANGELOG
  Fix project template binding (#169)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants