Add release contributors to CHANGELOG #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a nice way to add recognition and encourages updates the change-log. Two thumbs up from me. |
|
I agree with @Code-Grump |
|
@Code-Grump @ajeckmans pls approve it then. I will try to make a release after lunch. |
ajeckmans
approved these changes
Jun 10, 2024
gasparnagy
added a commit
that referenced
this pull request
Jun 12, 2024
* main: Reqnroll.Verify: Support for Verify v24 (Verify.Xunit v24.2.0) for .NET 4.7.2+ and .NET 6.0+. (#151, #170) use pull_request_template.md from the .github repo Fix spelling mistake in CONTRIBUTING.md Bump version fix config docs Add release contributors to CHANGELOG (#171) Update CONTRIBUTING with "draft PR" workflow and no force push after review fix CHANGELOG Fix project template binding (#169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to give more credit to the people who contribute to the open-source project, I recommend listing all contributors of a particular release in the change log (with GitHub handle & in alphabetical order).
My goal is to make this as an ongoing thing (everyone should add their own name as part of PR), but of course we can fix the changelog backwards as well.
What do you think?