Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add default for repo_token #50

Closed
wants to merge 1 commit into from
Closed

feat: add default for repo_token #50

wants to merge 1 commit into from

Conversation

babaric-dev
Copy link

No description provided.

@babaric-dev babaric-dev mentioned this pull request Feb 7, 2024
Closed
@babaric-dev
Copy link
Author

@NGPixel ping?

cyrilcolinet
cyrilcolinet reviewed Feb 15, 2024
View reviewed changes
Copy link

@cyrilcolinet cyrilcolinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't include the ${{ github.token }} yourself under the with: ?

@NGPixel
Copy link
Member

NGPixel commented Jun 11, 2024

I prefer an explicit declaration of the token under with:.

@NGPixel NGPixel closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrilcolinet cyrilcolinet cyrilcolinet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babaric-dev @NGPixel @cyrilcolinet