Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link to subtitle if it has accent marks #1873

Closed
Governa opened this issue May 12, 2020 · 2 comments
Closed

Broken link to subtitle if it has accent marks #1873

Governa opened this issue May 12, 2020 · 2 comments
Assignees
@NGPixel
Labels
bug Something isn't working contrib-easy Easy dev difficulty for contribution

Comments

@Governa
Copy link

Governa commented May 12, 2020 •
edited

Describe the bug
If a subtitle has an accent, any link to it won't work. Removing the accent, the link starts working.

If I write the URL manually to the browser's navigation bar it works even with the accent.

To Reproduce
In the Markdown editor add the following title and link:
# Tést
A lot of text
A lot of text
A lot of text
A lot of text
A lot of text
A lot of text
A lot of text
A lot of text
A lot of text
...
[Tést](#tést)

Save the page

Expected behavior
The link should move the page to the correct heading.

Host Info (please complete the following information):

  • OS: Ubuntu 16.04, Docker
  • Wiki.js version: 2.3.81
  • Database engine: sqlite
@NGPixel NGPixel added bug Something isn't working contrib-easy Easy dev difficulty for contribution labels May 12, 2020
@indierodo indierodo mentioned this issue May 28, 2020
Merged
NGPixel pushed a commit that referenced this issue May 30, 2020
@indierodo
fix: links to subtitles with special characters (#1949)
006dae1 
This issue is related to #1006 . The $vuetify.goTo() function expects a UTF-8 ev.target.hash . However, the markdown CRM URIencodes the ev.target.hash (this is great for browser compatibility, not so much for Vuetify)

Adding decodeURIComponent() to ev.target.hash fixes compatibility with Vuetify.

This fixes GitHub issue #1873
@shegren shegren mentioned this issue Jul 17, 2020
Closed
@ryprfpryr ryprfpryr mentioned this issue Aug 10, 2020
Closed
@craph
Copy link
Contributor

craph commented Sep 29, 2021

Hello @NGPixel I think this issue can be closed because the PR is merged right ?

@NGPixel NGPixel closed this as completed Sep 29, 2021
@Paulo-newtec
Copy link

Even after this merge, this bug is occurring with me.
I tested with 4 browsers: Firefox Mozilla and Opera functions correctly, but Microsoft Edge and Google Chrome maintains the bug, and the page don't scroll down to headers with accents.

jionggyu pushed a commit to jionggyu/wiki-2.5.302-patch that referenced this issue Jul 9, 2024
@indierodo
fix: links to subtitles with special characters (requarks#1949)
f6e739c 
This issue is related to requarks#1006 . The $vuetify.goTo() function expects a UTF-8 ev.target.hash . However, the markdown CRM URIencodes the ev.target.hash (this is great for browser compatibility, not so much for Vuetify)

Adding decodeURIComponent() to ev.target.hash fixes compatibility with Vuetify.

This fixes GitHub issue requarks#1873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NGPixel NGPixel

Labels
bug Something isn't working contrib-easy Easy dev difficulty for contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Governa @craph @NGPixel @Paulo-newtec