Skip to content

Commit

Permalink
Merge pull request #67 from aheckmann/master
Browse files Browse the repository at this point in the history
fixed global variable leaks
  • Loading branch information
mikeal committed Aug 27, 2011
2 parents 1200df5 + 8279362 commit 01c4466
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions main.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function isReadStream (rs) {

function copy (obj) {
var o = {}
for (i in obj) o[i] = obj[i]
for (var i in obj) o[i] = obj[i]
return o
}

Expand All @@ -74,7 +74,7 @@ function Request (options) {
options = {uri:options}
}

for (i in options) {
for (var i in options) {
this[i] = options[i]
}
if (!this.pool) this.pool = globalPool
Expand Down Expand Up @@ -281,7 +281,7 @@ Request.prototype.request = function () {
}
}
if (dest.setHeader) {
for (i in response.headers) {
for (var i in response.headers) {
dest.setHeader(i, response.headers[i])
}
dest.statusCode = response.statusCode
Expand Down Expand Up @@ -337,7 +337,7 @@ Request.prototype.request = function () {
options.headers['content-type'] = mimetypes.lookup(src.path.slice(src.path.lastIndexOf('.')+1))
} else {
if (src.headers) {
for (i in src.headers) {
for (var i in src.headers) {
if (!options.headers[i]) {
options.headers[i] = src.headers[i]
}
Expand Down Expand Up @@ -405,7 +405,7 @@ request.defaults = function (options) {
var def = function (method) {
var d = function (opts, callback) {
if (typeof opts === 'string') opts = {uri:opts}
for (i in options) {
for (var i in options) {
if (opts[i] === undefined) opts[i] = options[i]
}
return method(opts, callback)
Expand Down

0 comments on commit 01c4466

Please sign in to comment.