Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

getHeader incorrectly matches other headers containing name #825

Closed
therigu opened this Issue Feb 26, 2014 · 2 comments

Comments

Projects
None yet
2 participants

therigu commented Feb 26, 2014

getHeader incorrectly matches other headers containing name. See this example:

var assert = require('assert'),                                                                                                                                                                                                               
    request = require('request');                                                                                                                                                                                                             

var r = request('http://www.google.com', {                                                                                                                                                                                                    
    headers: {                                                                                                                                                                                                                                
        'Foo': 'bar',                                                                                                                                                                                                                         
        'Something-Else-Foo': 'not bar'                                                                                                                                                                                                       
    }                                                                                                                                                                                                                                         
});                                                                                                                                                                                                                                           

assert.equal(r.getHeader('Foo'), 'bar');

which gives output:

assert.js:92
  throw new assert.AssertionError({
        ^
AssertionError: "not bar" == "bar"
    at Object.<anonymous> (/Users/adam/Code/request/test-request.js:12:8)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:902:3

@mikeal mikeal added a commit that referenced this issue Feb 26, 2014

@mikeal mikeal Fixing #825 eddd488

@mikeal mikeal closed this Feb 26, 2014

Owner

mikeal commented Feb 26, 2014

great bug! thanks for logging, it's fixed now.

@nylen nylen pushed a commit to nylen/request that referenced this issue Oct 17, 2014

@mikeal mikeal Fixing #825 db691b0
Owner

mikeal commented Oct 29, 2014

this was actually not fixed :)

it is in caseless v0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment