No_proxy support

[samcday]

Should resolve #620 and #853

As per a comment in the code, I used this page as inspiration for how no_proxy should work: http://lynx.isc.org/current/breakout/lynx_help/keystrokes/environments.html

[samcday]

/cc @nylen - in case you didn't see this one :)

[nylen]

Looks good, but I do see one minor issue. Here's the condition for matching hostname:

hostname.indexOf(noProxyHost) === hostname.length - noProxyHost.length

This means that requests to google.com will not be proxied if no_proxy contains oogle.com. I'm sure there are other ways, but you could fix this by setting:

var hostname = self.uri.hostname.replace(/^\.*/, '.');
// ...
var noProxyHost = noProxyItemParts[0].replace(/^\.*/, '.');

Then, we could use a couple of tests for the case I mentioned above and maybe 1-2 more where the no_proxy variable is set but the proxy should still be used.

Finally, a couple of minor style nits:

• Move var hostname out of the for loop
• Use if ( rather than if(, and for ( rather than for(

With the above changes, I'd merge this.

[samcday]

Thanks for the feedback. I've made the changes.

Good spot on the fuzzy matching of hostname. That would have been a very unfortunate and hard to diagnose bug :O

I also realised that the no_proxy hostnames were case sensitive, so I've fixed that (and added a test).

FYI I tried to follow style as closely as I could. Turns out I was cargo culting if( because that's the style in the code that immediately precedes the new stuff I added. I tried my best! :)

Anyway, I think I've followed up all your comments. Let me know if you have any more, or if I missed anything.

[nylen]

Ah ok, the if ( spacing is just one of those minor OCD things that makes me twitchy.

The only issue I see now is that you have 3 test files which incorrectly say "proxy should NOT be called" in the comments.

I don't love that these tests are in separate files, but IMO this is our fault because our tests don't use a sane framework (see #1003). So, I'm inclined to accept this as-is and merge these tests into 1-2 files when we rewrite them.

If you fix the "should NOT be called" comments, I'll wait until Wednesday to give others a chance to weigh in, and merge it if no one else has by then.

[samcday]

Bah, right you are. After the tests expanded from what I expected to be 2-3 simple tests into what it is now, I got a bit lazy with the copy/pasta ;)

Should be all good now. I'll check in on Wednesday and see if this is good for merge :)

[nylen]

Thanks @samcday!