Fix to allow setting a requester on recursive calls to request.defaults
#1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 thanks - I'll merge this tomorrow if no one objects or beats me to it. |
|
awesome! |
nylen
added a commit
that referenced
this pull request
Sep 30, 2014
Fix to allow setting a `requester` on recursive calls to `request.defaults`
nylen
added a commit
to nylen/request
that referenced
this pull request
Oct 17, 2014
Fix to allow setting a `requester` on recursive calls to `request.defaults`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now in
request.defaultsin checks if themethod === requestto know if it should use the passed inrequesterThe issue is that on recursive calls to
request.defaultsthemethodwill not===torequest, it will be the function returned fromrequest.defaults.This PR changes the check to use
method === selfinstead so that you can set arequesteron recursive calls torequest.defaults