Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tests around using objects as values in a query string #1127

Merged
merged 2 commits into from
Oct 4, 2014

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Oct 3, 2014

I was curious how request encoded:

      request.get({
        url: 'http://' + host + ':' + port + '/user',
        json: true,
        qs: {
         where: { foo: 'bar' }
        }
      }, function (err, resp, body) {
        return done();
      });

And:

      request.get({
        url: 'http://' + host + ':' + port + '/user',
        json: true,
        qs: {
         order: ['foo', 'bar']
        }
      }, function (err, resp, body) {
        return done();
      });

So I put some tests around it.

@zeke
Copy link

zeke commented Oct 3, 2014

👌

mikeal added a commit that referenced this pull request Oct 4, 2014
added tests around using objects as values in a query string
@mikeal mikeal merged commit 477a862 into request:master Oct 4, 2014
nylen pushed a commit to nylen/request that referenced this pull request Oct 17, 2014
added tests around using objects as values in a query string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants