Clean up some code around setting the agent #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -626,15 +626,7 @@ Request.prototype.init = function (options) { | |||
| if (self.pool === false) { | |||
| self.agent = false | |||
| } else { | |||
| self.agent = self.agent || self.getAgent() | |||
| if (self.maxSockets) { | |||
There was a problem hiding this comment.
looks like this was an older setting we haven't supported in a while
There was a problem hiding this comment.
right, this was originally, if i remember correctly, intended to straddle compatibility between two major releases of Node with maxSocket changes. we can deprecate.
|
👍 from me, but I agree comment from @mikeal would be good. |
|
+1 from me. keep in mind that I wrote this code years ago so my memory may be a little off but we have pretty good tests for this stuff. |
nylen
added a commit
that referenced
this pull request
Oct 24, 2014
Clean up some code around setting the agent
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small cleanup around setting and getting the http/https agent. Looks like maxSockets weren't getting properly set when outside of init, so I moved that logic into
getAgent(), which has been renamed to_chooseAgent()since it doesn't literally get the current agent, as the name suggests. (Underscore added since it looks like it should only be called privately) (happy to bikeshed on a name, I'm not particularly tied to_chooseAgentand I'm sure there are better names out there)@mikeal I'd want your sign off on this since it's touching some older code