Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog #1207

Merged
merged 1 commit into from
Oct 24, 2014
Merged

Update changelog #1207

merged 1 commit into from
Oct 24, 2014

Conversation

nylen
Copy link
Member

@nylen nylen commented Oct 23, 2014

Fixes #1206.

@nylen
Copy link
Member Author

nylen commented Oct 23, 2014

Actually, the new changelog only has version labels back to v2.32.0, and older changes are in that section... I don't really like that.

edit - fixed

@nylen
Copy link
Member Author

nylen commented Oct 23, 2014

Figured out why - github-changes doesn't support fetching more than one page of tags from the GitHub API. I'll look into this and update back with progress.

edit - fixed

@nylen
Copy link
Member Author

nylen commented Oct 24, 2014

I think this is good to go now, would appreciate a quick review though.

@FredKSchott
Copy link
Contributor

looks great! Awesome stuff nylen

FredKSchott added a commit that referenced this pull request Oct 24, 2014
@FredKSchott FredKSchott merged commit f90a31f into request:master Oct 24, 2014
@FredKSchott
Copy link
Contributor

How does upcoming work? If it only gets run on release, wouldn't that section always be empty? Or does it update on merge?

@nylen
Copy link
Member Author

nylen commented Oct 24, 2014

yeah, it'll be empty in the future unless we decide to update it in between releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog requires manual work :(
2 participants