Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@simov I saw you mention updating eslint and decided to have a go at it.
In general I tried to avoid rocking the boat. There are some new options which raise some issues since the code style was not consistent. I just disabled these options in .eslintrc for now.
no-shadow
Sounds like a good idea to me. There are 21 no-shadow issues in the code right now.
key-spacing
At the moment the codebase uses a mixes of the two styles, which means eslint can't help us.
no-multi-spaces
There are a lot of inconsistencies in the code with this one:
vs
as well as: