-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - do not remove OAuth param when using OAuth realm #1679
Conversation
…thing in the array.
Right that definitely looks like a bug. I'll fix the tests tomorrow 👍 |
Awesome thanks |
@jhalickman can you pull https://github.com/simov/request/tree/oauth-realm-fix here? Then I'll merge it. |
Sorry I am confused, what do you want me to do? -- On July 17, 2015 at 10:52:03 AM, simo (notifications@github.com) wrote: @jhalickman can you pull https://github.com/simov/request/tree/oauth-realm-fix here? Then I'll merge it. — |
Just |
It looks like https://github.com/simov/request/commits/oauth-realm-fix already has my change in there, would I need to make any other changes? -- On July 17, 2015 at 11:31:46 AM, simo (notifications@github.com) wrote: Just git pull git@github.com:simov/request.git oauth-realm-fix into yours, and push again. If you have any difficulties I can figure out something on my end. You can apply the test fixes on your own too, we just need the tests passing here, in this PR, for the sake of completeness. — |
No, just execute the above command and push again, that's all. |
Ahh I get it so you merge from my PR. Should be done. -- On July 17, 2015 at 11:49:22 AM, simo (notifications@github.com) wrote: No, just execute the above command and push again, that's all. — |
Fix - do not remove OAuth param when using OAuth realm
Yep I Thanks 👍 |
Just curious if this is going to get into NPM in the near future? |
I think we should have a new release pretty soon. Probably on Monday. I'm going to wrap up the latest PR's during the weekend and publish. |
Awesome thanks for all the help! -- On July 17, 2015 at 12:06:26 PM, simo (notifications@github.com) wrote: I think we should have a new release pretty soon. Probably on Monday. I'm going to wrap up the latest PR's during the weekend and publish. — |
Version 2.59 is published #1683 |
…thing in the array.
When using oauth with a realm I was losing one of the parameters we needed, changing 1 to 0 adds realm at the front with out removing anything from the array.