Setting 'pool' to 'false' does NOT disable Agent pooling #261

Merged
merged 1 commit into from Jun 6, 2012

Projects

None yet

2 participants

@timshadel
Contributor

An incorrect check of if (!self.pool).. caused the globalPool overwrite self.pool before a check later in the code if (self.pool === false) ... which is intended to turn off pooling, but is never triggered. The result was that the typical http.Agent is used, with it's default max connections of 5.

--Tim Shadel github@timshadel.com

@timshadel timshadel Fixed `pool: false` to not use the global agent
An incorrect check caused the `globalPool` to be used whenever the
`pool` option was set to `false`.

--Tim Shadel <github@timshadel.com>
155e6ee
@mikeal mikeal merged commit 273713f into request:master Jun 6, 2012
@ghost Unknown referenced this pull request Sep 18, 2012
Closed

pool:false being ignored #259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment