Setting 'pool' to 'false' does NOT disable Agent pooling #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An incorrect check caused the `globalPool` to be used whenever the `pool` option was set to `false`. --Tim Shadel <github@timshadel.com>
mikeal
added a commit
that referenced
this pull request
Jun 6, 2012
Setting 'pool' to 'false' does NOT disable Agent pooling
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An incorrect check of
if (!self.pool)..caused theglobalPooloverwriteself.poolbefore a check later in the codeif (self.pool === false) ...which is intended to turn off pooling, but is never triggered. The result was that the typicalhttp.Agentis used, with it's default max connections of 5.--Tim Shadel github@timshadel.com