Moving response emit above setHeaders on destination streams #498

merged 1 commit into from Mar 29, 2013


None yet

2 participants


This change proposes moving self.emit('response', response); above the loop that ultimately calls self.pipeDest() on each of the destination streams.

This is to allow modifying the response headers before they are cloned to the destination Requests.

@mikeal mikeal merged commit bff3e0b into request:master Mar 29, 2013

Should have mentioned: Tests all pass :D

mikeal commented Mar 29, 2013

i merged it, did a pull, and then ran the tests so I already knew :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment