Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support the socks5 proxy. #648

Closed
wants to merge 1 commit into from
Closed

support the socks5 proxy. #648

wants to merge 1 commit into from

Conversation

sundq
Copy link

@sundq sundq commented Sep 6, 2013

implement the sock5 proxy.

@mattcg
Copy link

mattcg commented Oct 10, 2013

Hi - I'm the author of the libraries included in the commit. While I'm in favour of adding socks support to request, I don't think this is the best way to do it. The library files should not be added to lib/ - they should instead be added to package.json as dependencies.

If you like, close this pull request and I'll make another one with a clean implementation.

@mikeal
Copy link
Member

mikeal commented Oct 10, 2013

actually, the best way to do this is to publish this sock5-agent as its own module and depend on that. I'd gladly accept that patch.

@mattcg
Copy link

mattcg commented Oct 10, 2013

Thanks for jumping in!

The agents (there's one for HTTP and another for HTTPS) have already been published as their only modules... sorry, that's what I was trying to say :)

I'll make the pull request.

@mattcg mattcg mentioned this pull request Oct 10, 2013
@mikeal
Copy link
Member

mikeal commented Aug 27, 2014

no longer merges cleanly :(

@mikeal mikeal closed this Aug 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants