Fixes #595 Added support for HTTP_PROXY and HTTPS_PROXY environment variables, #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the proxy option isn't already set.
|
+1 |
|
+1 |
|
I don't see any reason not to merge this. I will do it tomorrow unless there are any objections. |
nylen
added a commit
that referenced
this pull request
Jul 7, 2014
Add support for HTTP[S]_PROXY environment variables. Fixes #595.
nylen
added a commit
to nylen/request
that referenced
this pull request
Oct 17, 2014
…v_vars Add support for HTTP[S]_PROXY environment variables. Fixes request#595.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the proxy option isn't already set. I added a test based off of test-proxy. I know it doesn't cover a number of different permutations on the variables. I can probably expand on it, if necessary. Leveraged the logic from npm, as noted in the issue comments.