Fix word consistency in readme #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`user` || `username` is used to describe the user field in the `auth` hash while `password` || `pass` was used to describe the password field. The order has been flipped for consistency: `pass` || `password`.
nylen
pushed a commit
to nylen/request
that referenced
this pull request
Oct 17, 2014
Fix word consistency in readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user||usernameis used to describe the user field in theauthhash whilepassword||passwas used to describe the password field. This is kind of ambiguous in my opinion so I flipped the order for consistency:pass||password.