Wrong oauth signature when multiple same param keys exist [updated] #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also handles array values node's querystring.parse.
Use querystring.parse to build oauth request params. Now realm prop in oauth options will be included in authorization header.
mikeal
added a commit
that referenced
this pull request
Aug 11, 2014
Wrong oauth signature when multiple same param keys exist [updated]
nylen
pushed a commit
to nylen/request
that referenced
this pull request
Oct 17, 2014
Wrong oauth signature when multiple same param keys exist [updated]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken @hyjin's commits for #612 and rebased them on top of master, and upgraded
oauth-signto make the test pass, as per request/oauth-sign#5 (comment)