Update Legacy Application Flow documentation #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a basic description of the Legacy Application Flow. It's pretty simple, but it took a bit of tooling around so this should save some people the trouble. I discovered that client_id is not passed from the OAuth2Session or LegacyApplicationClient when fetch_token is called, which I believe to be a bug.
|
Thanks for the docs patch @CorwinTanner! I'm going to merge this now, but can you elaborate on what you mean about this bug? |
Lukasa
added a commit
that referenced
this pull request
Jun 5, 2015
Update Legacy Application Flow documentation
|
An instance of LegacyApplicationClient is initialized with client_id and then passed into the initializer for OAuth2Session, which also stores a reference to client_id. However, when fetch_token is called on OAuth2Session, client_id is not included in the request. My workaround was to pass client_id as a kwarg in fetch_token, but it should be passed automatically since the session object already has it. I imagine it's a very low priority bug, but a bug nonetheless. If I get time this weekend, I will propose a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a basic description of the Legacy Application Flow. It's pretty simple, but it took a bit of tooling around so this should save some people the trouble.
I discovered that client_id is not passed from the OAuth2Session or LegacyApplicationClient when fetch_token is called, which I believe to be a bug.