Use requests-mock library, add tests for Slack compliance fix #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we're going to hand write response data, I'd rather we use requests-mock. It's maintained and raises errors that are not "ConnectionError" when a request changes. responses is a poor excuse for a mocking library for requests. Also, I'd rather we not mock any response bodies by hand, but that's a different arguement entirely. |
singingwolfboy
force-pushed
the
slack-compliance-tests
branch
from
8f25b37
to
9493f82
Compare
singingwolfboy
changed the title
|
@sigmavirus24 I had no idea that responses was not maintained, and that requests-mock was the library to use instead. I've updated my pull request. Does it look good? |
singingwolfboy
force-pushed
the
slack-compliance-tests
branch
from
9493f82
to
9f44f1b
Compare
singingwolfboy
force-pushed
the
slack-compliance-tests
branch
from
9f44f1b
to
658d0ef
Compare
|
👍 from me. |
|
👍 from me too. |
Lukasa
added a commit
that referenced
this pull request
Dec 23, 2015
Use requests-mock library, add tests for Slack compliance fix
|
👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are clearer and more accurate if we use the requests-mock library for mocking responses from requests. This pull request also adds a test for the Slack compliance fix.