Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instagram compliance fix #362

Merged

Conversation

AdamGold
Copy link
Contributor

@AdamGold AdamGold commented Jan 27, 2019

  • add tests

Instagram requires access_token to be inserted in the URL of the requests as stated here: https://www.instagram.com/developer/endpoints/.

@coveralls
Copy link

coveralls commented Jan 27, 2019

Coverage Status

Coverage increased (+0.3%) to 90.278% when pulling 9e60cf7 on AdamGold:feature/instagram-compliance-fix into 1495328 on requests:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.2%) to 86.733% when pulling 4ab3e59 on AdamGold:feature/instagram-compliance-fix into 1495328 on requests:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.2%) to 86.733% when pulling 4ab3e59 on AdamGold:feature/instagram-compliance-fix into 1495328 on requests:master.

@singingwolfboy
Copy link
Member

Can you explain what this is actually supposed to do, and why you need it for Instagram? It's hard to follow.

@AdamGold
Copy link
Contributor Author

@singingwolfboy Sure! Instagram requires access_token to be inserted in the URL of the requests as stated here: https://www.instagram.com/developer/endpoints/.
This was discussed here:
singingwolfboy/flask-dance#142

And I have a PR waiting for this compliance:
singingwolfboy/flask-dance#216

@AdamGold
Copy link
Contributor Author

AdamGold commented Jan 30, 2019

Coverage increased 🎉

@AdamGold
Copy link
Contributor Author

@singingwolfboy Did you get a chance to look?

@singingwolfboy
Copy link
Member

Looks great!

@singingwolfboy singingwolfboy merged commit 3d84271 into requests:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants