-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oauth workflows #46
Oauth workflows #46
Conversation
Yeah, I did think the README was a bit intense. I think we should use this PR as an umbrella PR for getting the docs into shape. |
It certainly was, served mainly as a crudge all in one guide awaiting docs setup. Let me know if anything pops out that I should change. I find it easier to preview the file in "raw" mode. If not this should be good to merge once the links are confirmed working in the README and I've included the sections in index.rst. |
I'm not entirely sure that we should merge this with the TODOs in place. I've enabled the RTD push hook, so the merge will trigger a docs rebuild with the TODOs in place. Not good. We should either replace them with text indicating 'coming later', fill them in, or remove the sections entirely. =) |
Ah yea the todos, will try and write that up tomorrow morning. Also noticed Keep suggestions coming :)
|
Added a section on token refresh. Changed the other todo to outline available flows with a 'docs coming soon' note. |
If you are not interested in token refreshing, always pass in a positive value | ||
for ``expires_in`` or omit it entirely. | ||
|
||
**0. The token we will use throughout the three examples.**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these subheaders should be actions, e.g. 'Define the token we will use through the three examples'.
While these docs certainly aren't perfect I thought they might do more good on readthedocs than sitting as a PR. Merging now and will improve incrementally instead. Same for #49. |
Thought I'd migrate the bulk of the current README to an OAuth1 workflow section of the upcoming docs (#39) to make it more clear/inviting to new comers. Also added a parallel track to the docs section showing how to use OAuth1Session.
Threw together a quick guide showing OAuth2 WebApplication flow with OAuth2Session as well.
Obs! The README changes add links to requests-oauthlib.readthedocs.org which is not yet setup...