Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oauth workflows #46

Merged
merged 11 commits into from
Jul 9, 2013
Merged

Oauth workflows #46

merged 11 commits into from
Jul 9, 2013

Conversation

ib-lundgren
Copy link
Member

Thought I'd migrate the bulk of the current README to an OAuth1 workflow section of the upcoming docs (#39) to make it more clear/inviting to new comers. Also added a parallel track to the docs section showing how to use OAuth1Session.

Threw together a quick guide showing OAuth2 WebApplication flow with OAuth2Session as well.

Obs! The README changes add links to requests-oauthlib.readthedocs.org which is not yet setup...

@Lukasa
Copy link
Member

Lukasa commented May 22, 2013

Yeah, I did think the README was a bit intense.

I think we should use this PR as an umbrella PR for getting the docs into shape.

@ib-lundgren
Copy link
Member Author

It certainly was, served mainly as a crudge all in one guide awaiting docs setup.

Let me know if anything pops out that I should change. I find it easier to preview the file in "raw" mode. If not this should be good to merge once the links are confirmed working in the README and I've included the sections in index.rst.

@Lukasa
Copy link
Member

Lukasa commented May 22, 2013

I'm not entirely sure that we should merge this with the TODOs in place. I've enabled the RTD push hook, so the merge will trigger a docs rebuild with the TODOs in place. Not good. We should either replace them with text indicating 'coming later', fill them in, or remove the sections entirely. =)

@ib-lundgren
Copy link
Member Author

Ah yea the todos, will try and write that up tomorrow morning. Also noticed
a minor thing in readme.

Keep suggestions coming :)
On May 22, 2013 7:58 PM, "Cory Benfield" notifications@github.com wrote:

I'm not entirely sure that we should merge this with the TODOs in place.
I've enabled the RTD push hook, so the merge will trigger a docs rebuild
with the TODOs in place. Not good. We should either replace them with text
indicating 'coming later', fill them in, or remove the sections entirely. =)


Reply to this email directly or view it on GitHubhttps://github.com//pull/46#issuecomment-18300024
.

@ib-lundgren
Copy link
Member Author

Added a section on token refresh. Changed the other todo to outline available flows with a 'docs coming soon' note.

@Lukasa Lukasa mentioned this pull request May 23, 2013
7 tasks
If you are not interested in token refreshing, always pass in a positive value
for ``expires_in`` or omit it entirely.

**0. The token we will use throughout the three examples.**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these subheaders should be actions, e.g. 'Define the token we will use through the three examples'.

@ib-lundgren
Copy link
Member Author

While these docs certainly aren't perfect I thought they might do more good on readthedocs than sitting as a PR. Merging now and will improve incrementally instead. Same for #49.

ib-lundgren added a commit that referenced this pull request Jul 9, 2013
@ib-lundgren ib-lundgren merged commit 8715922 into master Jul 9, 2013
@ib-lundgren ib-lundgren deleted the oauth_workflows branch July 9, 2013 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants