Close sessions created in the functional API

[sigmavirus24]

This is related to #1882 and #1685. By calling close on the session, we
clear the PoolManager operated by the Session and close all sockets.

Fixes #1882
Partially-fixes #1685

[Lukasa]

Eh, I'm +0.5. I still think that #1882 is unnecessary whining on the part of CPython, but never mind. ;)

[sigmavirus24]

@Lukasa it may be CPython being overly cautious but it will be a problem on PyPy. Stuff like this can cause an application to crash because there are too many file descriptors open. Others can explain why this is important to PyPy better than I can, but I'm very confident this is a worth while change.

My only qualm is worrying about users who may be accessing r.raw._pool. Granted they shouldn't be, but I'm worried about an influx of users who will complain that we broke X.

[Lukasa]

Yeah, that's a point. Can't really merge until 3.0.

[sigmavirus24]

I wouldn't think users relying on a private attribute would be given priority over a bug that could so easily affect PyPy users. If they're accessing _pool I'd be:

1. surprised and confused
2. unforgiving because they're accessing a private attribute

I can't think of a reason anyone would need to access a urllib3 connection pool frankly other than for the horrible debugging I've been going through and ideally no one else is really doing that.

[kevinburke]

Ship it :)

Kevin Burke
phone: 925.271.7005 | twentymilliseconds.com

On Fri, Nov 7, 2014 at 11:53 AM, Ian Cordasco notifications@github.com
wrote:

I wouldn't think users relying on a private attribute would be given
priority over a bug that could so easily affect PyPy users. If they're
accessing _pool I'd be:

1. surprised and confused
2. unforgiving because they're accessing a private attribute

I can't think of a reason anyone would need to access a urllib3
connection pool frankly other than for the horrible debugging I've been
going through and ideally no one else is really doing that.

—
Reply to this email directly or view it on GitHub
https://github.com/kennethreitz/requests/pull/2326#issuecomment-62202216
.

[alex]

woo