Add requirements.txt to MANIFEST.in #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 15, 2017
While I'm here, add COMMENT on specific supported Python versions [1] psf/requests#4192 QA: 3 failed [1], 480 passed, 11 skipped, 2 xpassed in 84.60 seconds MFH: 2017Q3 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@445845 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 15, 2017
While I'm here, add COMMENT on specific supported Python versions [1] psf/requests#4192 QA: 3 failed [1], 480 passed, 11 skipped, 2 xpassed in 84.60 seconds Approved by: ports-secteam (blanket: bugfix)
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 15, 2017
While I'm here, add COMMENT on specific supported Python versions [1] psf/requests#4192 QA: 3 failed [1], 480 passed, 11 skipped, 2 xpassed in 84.60 seconds MFH: 2017Q3
Lukasa
approved these changes
Jul 15, 2017
There was a problem hiding this comment.
Thanks for this!
However, if resources aren't available I think the tests should probably fail. That usually means someone screwed something up and it needs to be fixed. I appreciate that it causes you inconvenience, but it leads to us fixing problems that might otherwise slip past you.
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Apr 1, 2021
While I'm here, add COMMENT on specific supported Python versions [1] psf/requests#4192 QA: 3 failed [1], 480 passed, 11 skipped, 2 xpassed in 84.60 seconds Approved by: ports-secteam (blanket: bugfix)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three tests [1] rely on
requirements.txtbeing available. If the file is not present, the following error is observed in those tests:The latest (2.18.1) source distribution on PyPI does not include requirements.txt, which precludes successfully passing the tests.
This change adds the required file to the source distribution. An alternative is to use a different file already included in the sdist.
Additionally, skipping tests if a required resource (library, file, etc) is not available would be a user experience improvement.
[1] test_POSTBIN_GET_POST_FILES, test_POSTBIN_GET_POST_FILES_WITH_DATA, test_conflicting_post_params,