Improve behavior of toUrl

[jslegers]

The current implementation seems to suggest require.toUrl should only be used to get the path of an AMD module, even though the documentation also mentions a different use :

define(["require"], function(require) {
    var cssUrl = require.toUrl("./style.css");
});

Nevertheless, this method can't be used for all kinds of paths, like relative path that don't have an extension or paths that have components after the extension (which is not uncommon for a url).

This is because require.toUrl determines the position of the extension by taking the last dot of a path and considering everything starting from that dot as an extension.

This is very annoying, especially because this makes the behavior of require.toUrl different for RequireJS and the Dojo loader and results in invalid paths in RequireJS for even paths as simple and common as ../resources/.

This could easily be fixed by determining the position of the extension with a regex, like this :

/**
 * This method finds the index of the '.' of a file extension un a valid url.
 * Regex is based on https://stackoverflow.com/questions/6997262/how-to-pull-url-file-extension-out-of-url-string-using-javascript
 */
function findExtension( url ) {
    var matchext = url.match(/\.([^\./\?\#]+)($|\?|\#)/);
    return matchext ? matchext.index : -1;
}

My pull requests contains three changes to the source code :

• I replaced lastIndexOf with this new findExtension function for determining the position of the extension
• I renamed the moduleNamePlusExt argument of toUrl to path, to reflect that can be used in different context
• I updated the comment to toUrl

[jsf-clabot]

All committers have signed the CLA.