circulation: display pickup location name in patron profile #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a request is available for pickup, the location name was the short name. This PR corrects this problem: now the label display is the 'pickup_name' field from location. Closes rero/rero-ils#1300 Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-#1822-pickup-location-name
branch
from
dae6f9e
to
987b91e
Compare
benerken
approved these changes
Oct 29, 2020
Garfield-fr
approved these changes
Oct 29, 2020
iGormilhit
added
the
f: circulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a request is available for pickup, the location name was the short
name. This PR corrects this problem: now the label display is the
'pickup_name' field from location.
Authored-by: Renaud Michotte renaud.michotte@gmail.com
Why are you opening this PR?
Closes rero/rero-ils#1300
How to test?
Before
After
Code review check list