Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display the pickup location name in the circulation interface #1300

Closed
ManaDeweerdt opened this issue Oct 13, 2020 · 0 comments
Closed

Display the pickup location name in the circulation interface #1300

ManaDeweerdt opened this issue Oct 13, 2020 · 0 comments
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend
Milestone
v0.14.0

Comments

@ManaDeweerdt
Copy link
Contributor

Describe the bug
In the circulation interface, it displays the location name instead of the pickup location name.

To Reproduce
Steps to reproduce the behavior:

  1. Log in as a librarian or system librarian.
  2. Search for an user with an item 'to pickup'
  3. See the column 'pickup location''

Expected behavior
The pickup location should be displayed instead of the location name, like in the patron profile in the public interface.

  • server: [ils.test.rero.ch]
  • version: 0.12.0.
@ManaDeweerdt ManaDeweerdt added bug Breaks something but is not blocking triage f: circulation Concerns the circulation interface or backend labels Oct 13, 2020
@zannkukai zannkukai self-assigned this Oct 29, 2020
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Oct 29, 2020
@zannkukai
circulation: display pickup location name in patron profile
987b91e 
When a request is available for pickup, the location name was the short
name. This PR corrects this problem: now the label display is the
'pickup_name' field from location.

Closes rero/rero-ils#1300

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Oct 29, 2020
Merged
6 tasks
@zannkukai zannkukai added this to the v0.14.0 milestone Oct 29, 2020
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Oct 29, 2020
@zannkukai
circulation: display pickup location name in patron profile
d74e490 
When a request is available for pickup, the location name was the short
name. This PR corrects this problem: now the label display is the
'pickup_name' field from location.

Closes rero/rero-ils#1300

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Nov 2, 2020
@zannkukai
circulation: display pickup location name in patron profile
47e9b29 
When a request is available for pickup, the location name was the short
name. This PR corrects this problem: now the label display is the
'pickup_name' field from location.

Closes rero/rero-ils#1300

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Nov 4, 2020
@zannkukai
circulation: display pickup location name in patron profile
f9bc68c 
When a request is available for pickup, the location name was the short
name. This PR corrects this problem: now the label display is the
'pickup_name' field from location.

Closes rero/rero-ils#1300

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit removed the triage label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend
Projects
None yet
Milestone
v0.14.0
Development

No branches or pull requests
3 participants
@iGormilhit @zannkukai @ManaDeweerdt