Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

items: add spinner during request process #696

Merged
merged 1 commit into from Sep 9, 2021
Merged

items: add spinner during request process #696

merged 1 commit into from Sep 9, 2021

Conversation

zannkukai
Copy link
Contributor

Closes rero/rero-ils#2317.

Co-authored-by: Renaud Michotte renaud.michotte@gmail.com

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai self-assigned this Aug 20, 2021
@github-actions github-actions bot added the f: professional ui Professional interface label Aug 20, 2021
@iGormilhit iGormilhit added this to New in RERO ILS PRs via automation Aug 25, 2021
@iGormilhit iGormilhit added this to the v1.5.0 milestone Aug 25, 2021
@iGormilhit iGormilhit moved this from New to PR for next release in RERO ILS PRs Aug 25, 2021
@iGormilhit iGormilhit changed the title item: add spinner during request process items: add spinner during request process Aug 25, 2021
iGormilhit
iGormilhit reviewed Aug 25, 2021
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

items: add spinner during request process

* Closes rero/rero-ils#2317.

Items with an s, plural form. Bullet point for the closes.

iGormilhit
iGormilhit approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@zannkukai
items: add spinner during request process
4b0a91e 
* Closes rero/rero-ils#2317.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
iGormilhit
iGormilhit approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@iGormilhit iGormilhit moved this from PR for next release to Fix on production in RERO ILS PRs Sep 9, 2021
@iGormilhit iGormilhit modified the milestones: v1.5.0, v1.4.10 Sep 9, 2021
@iGormilhit iGormilhit merged commit ff6f207 into rero:dev Sep 9, 2021
RERO ILS PRs automation moved this from Fix on production to Closed PR Sep 9, 2021
@zannkukai zannkukai deleted the zan-fix-issue-2317 branch October 7, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@sebdeleze sebdeleze sebdeleze approved these changes

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

Assignees

@zannkukai zannkukai

Labels
f: professional ui Professional interface
Projects
No open projects
RERO ILS PRs
  
Closed PR
Milestone
v1.4.10
Development

Successfully merging this pull request may close these issues.

Disable "add request" button after first click
4 participants
@zannkukai @jma @iGormilhit @sebdeleze