Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable "add request" button after first click #2317

Closed
zannkukai opened this issue Aug 19, 2021 · 0 comments · Fixed by rero/rero-ils-ui#696
Closed

Disable "add request" button after first click #2317

zannkukai opened this issue Aug 19, 2021 · 0 comments · Fixed by rero/rero-ils-ui#696
Assignees
@zannkukai
Labels
enhancement Improvement of an existing feature f: professional ui Professional interface p-Low Low priority

Comments

@zannkukai
Copy link
Contributor

How it works

In the professional interface, we you add a request for a patron on a item, the system display a modal form.
After filling the form, when you click on "add request" button, the system will proceed the HTTP call but nothing on the interface tell the user that the request is processing

image

Improvement suggestion

After the click on "add request" button, disable the button + add spinner icon into it. When the request succeeded, go back to the initial button state (with a toastr message --> already existsing)
@zannkukai zannkukai added enhancement Improvement of an existing feature f: professional ui Professional interface triage p-Low Low priority labels Aug 19, 2021
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Aug 20, 2021
@zannkukai
item: add spinner during request process
41f0b51 
Closes rero/rero-ils#2317.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai self-assigned this Aug 20, 2021
@zannkukai zannkukai removed the triage label Aug 20, 2021
@zannkukai zannkukai mentioned this issue Aug 20, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Aug 26, 2021
@zannkukai
items: add spinner during request process
f82830b 
* Closes rero/rero-ils#2317.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Aug 30, 2021
@zannkukai
items: add spinner during request process
4b0a91e 
* Closes rero/rero-ils#2317.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
iGormilhit pushed a commit to rero/rero-ils-ui that referenced this issue Sep 9, 2021
@zannkukai
items: add spinner during request process
ff6f207 
* Closes rero/rero-ils#2317.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
enhancement Improvement of an existing feature f: professional ui Professional interface p-Low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

items: add spinner during request process zannkukai/rero-ils-ui
1 participant
@zannkukai