Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A librarian shouldn't be able to resolve fees of item not belonging to the login location #1533

Closed
ManaDeweerdt opened this issue Dec 1, 2020 · 1 comment · Fixed by #1773
Closed

A librarian shouldn't be able to resolve fees of item not belonging to the login location #1533

ManaDeweerdt opened this issue Dec 1, 2020 · 1 comment · Fixed by #1773
Assignees
@jma
Labels
effort: important US candidate enhancement Improvement of an existing feature f: user management p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.2.0

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Dec 1, 2020 •
edited

How it works

Currently, we can resolve a fee for all locations of the organisation.

Improvement suggestion

Add a dropdown in the 'pay all' button : 'pay all for my library'.

Additionally (public and pro interface):
Add a new column 'library' between the category and the total fee amount.
@ManaDeweerdt ManaDeweerdt added enhancement Improvement of an existing feature triage labels Dec 1, 2020
@iGormilhit iGormilhit added effort: important US candidate f: user management p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels Dec 2, 2020
@zannkukai
Copy link
Contributor

zannkukai commented Dec 2, 2020 •
edited

Additionally (public and pro interface) :
Add a new column 'location' with the library code.

@ManaDeweerdt Where ? how ?

@ManaDeweerdt ManaDeweerdt changed the title Fees: a librarian should only resolve fees of owning item Fees : a librarian shouldn't be able to resolve fees of item not belonging to the login location Dec 10, 2020
@ManaDeweerdt ManaDeweerdt added p-High High priority (to be solved in the 2-3 next months) and removed p-Medium Medium priority (to be solved within 1-2 years) labels Feb 1, 2021
@iGormilhit iGormilhit added this to the v1.2.0 milestone Feb 8, 2021
jma added a commit to jma/rero-ils that referenced this issue Mar 16, 2021
@jma
transaction: add library for patron transactions
cf03d64 
* Adds the library pid in the patron transaction index if the
  transaction is related to a loan.
* Closes rero#1533.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Mar 16, 2021
@jma
transaction: add library for patron transactions
1276c31 
* Adds the library pid in the patron transaction index if the
  transaction is related to a loan.
* Closes rero#1533.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma mentioned this issue Mar 16, 2021
Merged
7 tasks
jma added a commit to jma/rero-ils that referenced this issue Mar 17, 2021
@jma
transaction: add library for patron transactions
f60bc78 
* Adds the library pid in the patron transaction index if the
  transaction is related to a loan.
* Closes rero#1533.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma self-assigned this Mar 17, 2021
@jma jma modified the milestones: v1.1.0, v1.2.0 Mar 17, 2021
@jma jma closed this as completed in #1773 Mar 30, 2021
jma added a commit that referenced this issue Mar 30, 2021
@jma
transaction: add library for patron transactions
0a67262 
* Adds the library pid in the patron transaction index if the
  transaction is related to a loan.
* Closes #1533.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@iGormilhit iGormilhit changed the title Fees : a librarian shouldn't be able to resolve fees of item not belonging to the login location A librarian shouldn't be able to resolve fees of item not belonging to the login location May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jma jma

Labels
effort: important US candidate enhancement Improvement of an existing feature f: user management p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

transaction: add library for patron transactions jma/rero-ils
4 participants
@jma @iGormilhit @zannkukai @ManaDeweerdt