transaction: add library for patron transactions #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauren-d
approved these changes
Mar 16, 2021
* Adds the library pid in the patron transaction index if the transaction is related to a loan. * Closes rero#1533. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
force-pushed
the
maj-fees-pay-all-by-library
branch
from
1276c31
to
f60bc78
Compare
benerken
approved these changes
Mar 17, 2021
7 tasks
rerowep
approved these changes
Mar 20, 2021
| @@ -38,3 +38,7 @@ def enrich_patron_transaction_data(sender, json=None, record=None, index=None, | |||
| 'pid': record.document_pid, | |||
| 'type': 'documents' | |||
| } | |||
| json['library'] = { | |||
| 'pid': record.library_pid, | |||
| 'type': 'libraries' | |||
There was a problem hiding this comment.
I do not know. I made this to be consistent with documents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transaction is related to a loan.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
Code review check list