Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requests for patrons by librarians are impossible with librarian accounts of a specific library #2234

Closed
iGormilhit opened this issue Jul 22, 2021 · 5 comments · Fixed by #2260
Closed

Requests for patrons by librarians are impossible with librarian accounts of a specific library #2234

iGormilhit opened this issue Jul 22, 2021 · 5 comments · Fixed by #2260
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-High High priority (to be solved in the 2-3 next months) production Issue specifically spotted on the production server

Comments

@iGormilhit
Copy link

iGormilhit commented Jul 22, 2021 •
edited by pronguen
Loading

Describe the bug

When connected as a librarian working at BPUN (RBNJ), it impossible to create request for patrons on every item that are not owned by the BPUN library. The BPUN library deactivate request on its own items during holidays.

The pickup location does not matter, for every pickup the request is impossible.

-> Hypothesis: if the pick-up location of the login library does not allow the requests, there are server errors.

To Reproduce

  1. Log in as a librarian in the professional interface (try on bib.test.rero.ch).
  2. Verify the selected library is BPUN.
  3. Find an item to request in the professional interface.
  4. Try to place a request for a patron. See the error. (See screenshot below).

Expected behavior

The request should succed.

Context

Screenshots

ksnip_20210722-170428

Additional context

From the patron point of view, any request with a pickup libary of the BPUN will also fail.
@iGormilhit iGormilhit added f: circulation Concerns the circulation interface or backend bug Breaks something but is not blocking p-High High priority (to be solved in the 2-3 next months) production Issue specifically spotted on the production server labels Jul 22, 2021
@pronguen
Copy link
Contributor

pronguen commented Jul 27, 2021 •
edited
Loading

I was not able to reproduce this behaviour. I could place a request on this document (holdings of Bibliothèque des Archives de l'Etat de Neuchâtel (Neuchâtel): Réserve) as a patron, as a BPUN librarian AND as a BPUN system librarian.

We see that the items of the location Bibliothèque publique de Neuchâtel - Fonds d'étude : Réserve cannot be requested, because requests were disabled on the location (usually, items of this item type can be requested). This is also correct.

Done on bib.test.rero.ch

@iGormilhit
Copy link
Author

iGormilhit commented Jul 28, 2021 •
edited
Loading

@pronguen

On https://bib.test.rero.ch, as a patron, I tried to place a request on the same document, holdings of Bibliothèque des Archives de l'Etat de Neuchâtel (Neuchâtel): Réserve), selecting Bibliothèque publique de Neuchâtel - lecture publique as a pickup location, and the request fails: https://bib.test.rero.ch/api/item/patron_request 403 forbidden.

ksnip_20210728-110507

As a librarian, placing a request on the same item, on behalf of a patron, selecting Bibliothèque publique de Neuchâtel - lecture publique as a pickup location, and the request fails: https://bib.test.rero.ch/api/item/request 403 forbidden.

ksnip_20210728-111406

I have the exact same behavior on https://bib.rero.ch.

I'll try to reproduce on https://ils.test.rero.ch.

@pronguen
Copy link
Contributor

@iGormilhit I could reproduce it on ils.test.rero.ch:

  1. Disallow requests on all locations of a library
  2. Log in as a librarian of this library
  3. Try to do a request on an item of another library (no matter what the pick-up location is)
  4. Error in the screenshot

image

Expected behaviour:
Disallowing request on a location has an effect only on the items of this location

@iGormilhit
Copy link
Author

@pronguen Thanks a lot!

This also prevent a patron to place a request on any item not belonging to this library, but with this library as a pickup location.

jma added a commit to jma/rero-ils that referenced this issue Aug 2, 2021
@jma
circulation: fix request with different locations
981f047 
* Checks the owning location `allow_request` property to decide if an item can be requested.
* Closes rero#2234.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma mentioned this issue Aug 2, 2021
Merged
7 tasks
jma added a commit to jma/rero-ils that referenced this issue Aug 3, 2021
@jma
circulation: fix request with different locations
ae41fd9 
* Checks the owning location `allow_request` property to decide if an item can be requested.
* Closes rero#2234.
* Logs an error and do a db rollback for holding views.
* Fixes tests that failed every two monthes.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@pronguen pronguen mentioned this issue Aug 3, 2021
Closed
jma added a commit to jma/rero-ils that referenced this issue Aug 4, 2021
@jma
circulation: fix request with different locations
53828f1 
* Checks the owning location `allow_request` property to decide if an item can be requested.
* Closes rero#2234.
* Logs an error and do a db rollback for holding views.
* Fixes tests that failed every two monthes.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Aug 9, 2021
@jma
circulation: fix request with different locations
efdc4ed 
* Checks the owning location `allow_request` property to decide if an item can be requested.
* Closes rero#2234.
* Logs an error and do a db rollback for holding views.
* Fixes tests that failed every two monthes.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma closed this as completed in #2260 Aug 9, 2021
jma added a commit that referenced this issue Aug 9, 2021
@jma
circulation: fix request with different locations
c8c58d6 
* Checks the owning location `allow_request` property to decide if an item can be requested.
* Closes #2234.
* Logs an error and do a db rollback for holding views.
* Fixes tests that failed every two monthes.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@pronguen pronguen mentioned this issue Aug 12, 2021
Merged
7 tasks
@pronguen
Copy link
Contributor

@iGormilhit This bug still happens on ils.test.rero.ch (v.1.4.11). Could you verify on your side and reopen the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-High High priority (to be solved in the 2-3 next months) production Issue specifically spotted on the production server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

circulation: fix request with different locations jma/rero-ils
2 participants
@iGormilhit @pronguen